Readme: remove outdated manual installation instructions #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majosm
approved these changes
Aug 16, 2023
Comment on lines
-40
to
-47
| ## Running on systems with lots of nodes (>256) | ||
| On large systems, the file system can become a bottleneck for loading Python | ||
| packages. On these systems, it is recommended to create a zip file with the | ||
| modules to speed up the startup process. This can be done by specifying the | ||
| `--modules` parameter to `install.sh`, or by running `makezip.sh` after | ||
| installation. | ||
|
|
||
| See https://github.com/illinois-ceesd/planning/issues/26 for more details. |
There was a problem hiding this comment.
Is this potentially something we still need to worry about? If so, should we make an issue? (Or we could just wait until someone runs into it again I guess...)
There was a problem hiding this comment.
We haven't really encountered this issue "in the wild" I think. Startup time is mostly determined by compile time currently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are unlikely to be working anymore, since we put a lot of effort in recording package dependencies in mirgecom requirements/conda-env itself.
The 'Running on lots of nodes' section is also completely outdated, I think it's better to keep that documentation in mirgecom itself.